Mercurial > prosody-modules
view mod_lib_ldap/dev/t/TestConnection.pm @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | 07582b8aaf84 |
children |
line wrap: on
line source
package TestConnection; use strict; use warnings; use parent 'AnyEvent::XMPP::IM::Connection'; use 5.010; our $HOST = 'localhost'; our $TIMEOUT = 5; our %PASSWORD_FOR = ( one => '12345', two => '23451', three => '34512', four => '45123', five => '51234', six => '123456', seven => '1234567', ); sub new { my ( $class, $username, %options ) = @_; my $cond = AnyEvent->condvar; my $timer = AnyEvent->timer( after => $TIMEOUT, cb => sub { $cond->send('timeout'); }, ); my $self = $class->SUPER::new( username => $username, domain => $HOST, password => $options{'password'} // $PASSWORD_FOR{$username}, resource => 'test bot', ); $self->reg_cb(error => sub { my ( undef, $error ) = @_; $cond->send($error->string); }); bless $self, $class; $self->{'condvar'} = $cond; $self->{'timeout_timer'} = $timer; $self->connect; return $self; } sub cond { my ( $self ) = @_; return $self->{'condvar'}; } 1;