Mercurial > prosody-modules
view mod_log_slow_events/README.markdown @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | d276bf3f0464 |
children |
line wrap: on
line source
--- labels: - 'Stage-Stable' summary: Log warning when event handlers take too long ... Introduction ============ Most activities in Prosody take place within our built-in events framework, for example stanza processing and HTTP request handling, authentication, etc. Modules are able to execute code when an event occurs, and they should return as quickly as possible. Poor performance (e.g. slow or laggy server) can be caused by event handlers that are slow to respond. This module is able to monitor how long each event takes to be processed, and logs a warning if an event takes above a certain amount of time, including providing any details about the event such as the user or stanza that triggered it. The aim is to help debug why a server may not be as responsive as it should be, and ultimately which module is to blame for that. Configuration ====================== There is a single configuration option: ``` -- Set the number of seconds an event may take before -- logging a warning (fractional values are ok) log_slow_events_threshold = 0.5 ``` Metrics ======= In addition to the log messages, a new 'slow_events' metric will be exported to your configured stats backend (if any). Compatibility ------------- ------- -------------- trunk Works 0.10 Works 0.9 Doesn't work 0.8 Doesn't work ------- --------------