Mercurial > prosody-modules
view mod_measure_stanza_counts/mod_measure_stanza_counts.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | 33b1b6ff23d8 |
children |
line wrap: on
line source
module:set_global() local filters = require"util.filters"; local stanzas_in = module:metric( "counter", "received", "", "Stanzas received by Prosody", { "session_type", "stanza_kind" } ) local stanzas_out = module:metric( "counter", "sent", "", "Stanzas sent by prosody", { "session_type", "stanza_kind" } ) local stanza_kinds = { message = true, presence = true, iq = true }; local function rate(metric_family) return function (stanza, session) if stanza.attr and not stanza.attr.xmlns and stanza_kinds[stanza.name] then metric_family:with_labels(session.type, stanza.name):add(1); end return stanza; end end local function measure_stanza_counts(session) filters.add_filter(session, "stanzas/in", rate(stanzas_in)); filters.add_filter(session, "stanzas/out", rate(stanzas_out)); end filters.add_filter_hook(measure_stanza_counts);