Mercurial > prosody-modules
view mod_measure_storage/mod_measure_storage.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | 04ae5b45e6c7 |
children |
line wrap: on
line source
module:set_global() local function return_args_after_calling(f, ...) f(); return ... end local function time_method(module, store_name, store_type, method_name, method_function) local opt_use_tags = module:get_option_boolean("measure_storage_tagged_metric", false); local metric_name, metric_tags; if opt_use_tags then metric_name, metric_tags = "storage_operation", ("store_name:%s,store_type:%s,store_operation:%s"):format(store_name, store_type, method_name); else metric_name = store_name.."_"..store_type.."_"..method_name; end local measure_operation_started = module:measure(metric_name, "times", metric_tags); return function (...) module:log("debug", "Measuring storage operation %s (%s)", metric_name, metric_tags or "no tags"); local measure_operation_complete = measure_operation_started(); return return_args_after_calling(measure_operation_complete, method_function(...)); end; end local function wrap_store(module, store_name, store_type, store) local new_store = setmetatable({}, { __index = function (t, method_name) local original_method = store[method_name]; if type(original_method) ~= "function" then if original_method then rawset(t, method_name, original_method); end return original_method; end local timed_method = time_method(module, store_name, store_type, method_name, original_method); rawset(t, method_name, timed_method); return timed_method; end; }); return new_store; end local function hook_event(module) module:hook("store-opened", function(event) event.store = wrap_store(module, event.store_name, event.store_type or "keyval", event.store); end); end function module.load() hook_event(module); end function module.add_host(module) hook_event(module); end