Mercurial > prosody-modules
view mod_motd_sequential/mod_motd_sequential.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | 8412592f3011 |
children |
line wrap: on
line source
-- Prosody IM -- Copyright (C) 2008-2010 Matthew Wild -- Copyright (C) 2008-2010 Waqas Hussain -- Copyright (C) 2010 Jeff Mitchell -- -- This project is MIT/X11 licensed. Please see the -- COPYING file in the source package for more information. -- local core_route_stanza = prosody.core_route_stanza; local host = module:get_host(); local motd_jid = module:get_option("motd_jid") or host; local datamanager = require "util.datamanager"; local ipairs = ipairs; local motd_sequential_messages = module:get_option("motd_sequential_messages") or {}; local motd_messagesets = {}; local max = 1; for i, message in ipairs(motd_sequential_messages) do motd_messagesets[i] = message; max = i; end local st = require "util.stanza"; module:hook("resource-bind", function (event) local session = event.session; local alreadyseen_list = datamanager.load(session.username, session.host, "motd_sequential_seen") or { max = 0 }; local alreadyseen = alreadyseen_list["max"] + 1; local motd_stanza; for i = alreadyseen, max do motd_stanza = st.message({ to = session.username..'@'..session.host, from = motd_jid }, motd_messagesets[i]); core_route_stanza(hosts[host], motd_stanza); module:log("debug", "MOTD send to user %s@%s", session.username, session.host); end alreadyseen_list["max"] = max; datamanager.store(session.username, session.host, "motd_sequential_seen", alreadyseen_list); end);