Mercurial > prosody-modules
view mod_muc_config_restrict/mod_muc_config_restrict.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | ed7431fd3b47 |
children |
line wrap: on
line source
local is_admin = require "core.usermanager".is_admin; local t_remove = table.remove; local restricted_options = module:get_option_set("muc_config_restricted", {})._items; function handle_config_submit(event) local stanza = event.stanza; if is_admin(stanza.attr.from, module.host) then return; end -- Don't restrict admins local fields = event.fields; for option in restricted_options do fields[option] = nil; -- Like it was never there end end function handle_config_request(event) if is_admin(event.actor, module.host) then return; end -- Don't restrict admins local form = event.form; for i = #form, 1, -1 do if restricted_options[form[i].name] then t_remove(form, i); end end end module:hook("muc-config-submitted", handle_config_submit); module:hook("muc-config-form", handle_config_request);