Mercurial > prosody-modules
view mod_muc_hats_api/mod_muc_hats_api.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | 1f90e333b1d8 |
children |
line wrap: on
line source
local mod_muc = module:depends("muc"); function add_user_hat(user_jid, room_jid, hat_id, attachment) local room = mod_muc.get_room_from_jid(room_jid); if not room then return nil, "item-not-found", "no such room"; end local user_aff = room:get_affiliation(user_jid); if not user_aff then return nil, "item-not-found", "user not affiliated with room"; end local aff_data = room:get_affiliation_data(user_jid) or {}; local hats = aff_data.hats; if not hats then hats = {}; aff_data.hats = hats; end hats[hat_id] = { active = attachment.active; required = attachment.required; title = attachment.title; }; local ok, err = room:set_affiliation(true, user_jid, user_aff, nil, aff_data); if not ok then return nil, err; end return true; end function remove_user_hat(user_jid, room_jid, hat_id) local room = mod_muc.get_room_from_jid(room_jid); if not room then return nil, "item-not-found", "no such room"; end local user_aff = room:get_affiliation(user_jid); if not user_aff then return nil, "item-not-found", "user not affiliated with room"; end local aff_data = room:get_affiliation_data(user_jid); local hats = aff_data and aff_data.hats; if not hats then return true; end hats[hat_id] = nil; local ok, err = room:set_affiliation(true, user_jid, user_aff, nil, aff_data); if not ok then return nil, err; end return true; end function set_user_hats(user_jid, room_jid, new_hats) local room = mod_muc.get_room_from_jid(room_jid); if not room then return nil, "item-not-found", "no such room"; end local user_aff = room:get_affiliation(user_jid); if not user_aff then return nil, "item-not-found", "user not affiliated with room"; end local aff_data = room:get_affiliation_data(user_jid) or {}; aff_data.hats = new_hats; local ok, err = room:set_affiliation(true, user_jid, user_aff, nil, aff_data); if not ok then return nil, err; end return true; end