Mercurial > prosody-modules
view mod_presence_dedup/mod_presence_dedup.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | 19924a2c4a48 |
children |
line wrap: on
line source
local st = require "util.stanza"; local cache = require "util.cache"; local add_filter = require "util.filters".add_filter; local cache_size = module:get_option_number("presence_dedup_cache_size", 100); -- stanza equality tests local function attr_eq(a, b) if a == b then return true; end -- unlikely but not impossible for k,v in pairs(a) do if b[k] ~= v then return false; end end for k,v in pairs(b) do if a[k] ~= v then return false; end end return true; end local function st_eq(a, b) if a == b then return true; end if type(b) ~= "table" then return false; end if getmetatable(b) ~= st.stanza_mt then return false; end if a.name ~= b.name then return false; end if #a ~= #b then return false; end if not attr_eq(a.attr, b.attr) then return false; end for i = 1, #a do if not st_eq(a[i], b[i]) then return false; end end return true; end local function dedup_presence(stanza, session) if session.presence_cache and session.presence and getmetatable(stanza) == st.stanza_mt and stanza.name == "presence" and stanza.attr.xmlns == nil and stanza.attr.from then local cached = session.presence_cache:get(stanza.attr.from); if st_eq(stanza, cached) then return nil; else session.presence_cache:set(stanza.attr.from, st.clone(stanza)); end end return stanza; end module:hook("presence/initial", function (event) local session = event.origin; session.presence_cache = cache.new(cache_size); add_filter(session, "stanzas/out", dedup_presence, 90); end);