Mercurial > prosody-modules
view mod_s2s_auth_samecert/mod_s2s_auth_samecert.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | c9397cd5cfe6 |
children |
line wrap: on
line source
module:set_global() local hosts = prosody.hosts; module:hook("s2s-check-certificate", function(event) local session, cert = event.session, event.cert; if not cert or session.direction ~= "incoming" then return end local outgoing = hosts[session.to_host].s2sout[session.from_host]; if outgoing and outgoing.type == "s2sout" and outgoing.secure and outgoing.conn:socket():getpeercertificate():pem() == cert:pem() then session.log("debug", "Certificate matches that of s2sout%s", tostring(outgoing):match("[a-f0-9]+$")); session.cert_identity_status = outgoing.cert_identity_status; session.cert_chain_status = outgoing.cert_chain_status; return true; end end, 1000);