Mercurial > prosody-modules
view mod_tlsfail/mod_tlsfail.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | 7009e16192fa |
children |
line wrap: on
line source
local st = require "util.stanza"; local xmlns_starttls = 'urn:ietf:params:xml:ns:xmpp-tls'; local starttls_attr = { xmlns = xmlns_starttls }; local s2s_feature = st.stanza("starttls", starttls_attr); local starttls_failure = st.stanza("failure", starttls_attr); module:hook("stream-features", function(event) local features = event.features; features:add_child(s2s_feature); end); module:hook("s2s-stream-features", function(event) local features = event.features; features:add_child(s2s_feature); end); -- Hook <starttls/> module:hook("stanza/urn:ietf:params:xml:ns:xmpp-tls:starttls", function(event) local origin = event.origin; (origin.sends2s or origin.send)(starttls_failure); origin:close(); return true; end);