mod_http_oauth2: Add role selector to consent page List includes all roles available to the user, if more than one. Defaults to either the first role in the scope string or the users primary role. Earlier draft listed all roles, but having options that can't be selected is bad UX and the entire list of all roles on the server could be long, and perhaps even sensitive. Allows e.g. picking a role with fewer permissions than what might otherwise have been selected. UX wise, doing this with more checkboxes or possibly radio buttons would have been confusion and/or looked messier. Fixes the previous situation where unselecting a role would default to the primary role, which could be more permissions than requested.

local jid_split = require "util.jid".split;
local jid_bare = require "util.jid".bare;
local load_roster = require "core.rostermanager".load_roster;

local blocked_servers = module:get_option_set("block_s2s_subscriptions")._items;

function filter_presence(event)
	if blocked_servers[event.origin.from_host] and event.stanza.attr.type == "subscribe" then
		local stanza = event.stanza;
		local to_user, to_host = jid_split(stanza.attr.to);
		local roster = load_roster(to_user, to_host);
		if roster and roster[jid_bare(stanza.attr.from)] then
			return; -- In roster, pass through
		end
		return true; -- Drop
	end
end

module:hook("presence/bare", filter_presence, 200); -- Client receiving