# HG changeset patch # User Kim Alvefur # Date 1605453949 -3600 # Node ID 64aa1d9d70ac49b6ace6ef509d2dcedb3240aba8 # Parent f3fbfde9683d3988cb0260077c4d43b917c561bc mod_rest: Catch and log errors in callback promise chain From the code it looks like it should be possible to reply to an error stanza, but it did not. Turns out I was saved by my local developer mode module which throws errors if an attempt is made to create an errror reply to an error stanza. However nothing collects this error from the promise, so all I got was confusion. diff -r f3fbfde9683d -r 64aa1d9d70ac mod_rest/mod_rest.lua --- a/mod_rest/mod_rest.lua Sun Nov 15 15:41:52 2020 +0100 +++ b/mod_rest/mod_rest.lua Sun Nov 15 16:25:49 2020 +0100 @@ -392,6 +392,8 @@ function (err) module:log_status("error", "Could not connect to callback URL %q: %s", rest_url, err); origin.send(st.error_reply(stanza, "wait", "recipient-unavailable", err.text)); + end):catch(function (err) + module:log("error", "Error[rest]: %s", err); end); return true;