# HG changeset patch
# User Marco Cirillo <maranda@lightwitch.org>
# Date 1326579478 0
# Node ID 7310ceb7564ff2c84e2ea3ed80bf19d3230b7289
# Parent  d1e83cb1288556404221b7a9a82e96e320439546
mod_register_json: checking out if the user creation succeeded or not is good practice.

diff -r d1e83cb12885 -r 7310ceb7564f mod_register_json/mod_register_json.lua
--- a/mod_register_json/mod_register_json.lua	Sun Jan 15 02:56:51 2012 +0500
+++ b/mod_register_json/mod_register_json.lua	Sat Jan 14 22:17:58 2012 +0000
@@ -96,10 +96,15 @@
 					module:log("debug", "%s supplied an username containing invalid characters: %s", user, username)
 					return http_response(406, "Supplied username contains invalid characters, see RFC 6122.")
 				else
-					usermanager.create_user(username, req_body["password"], req_body["host"])
-					hosts[req_body["host"]].events.fire_event("user-registered", { username = username, host = req_body["host"], source = "mod_register_json", session = { ip = req_body["ip"] } })
-					module:log("debug", "%s registration data submission for %s@%s is successful", user, username, req_body["host"])
-					return http_response(200, "Done.")
+					local ok, error = usermanager.create_user(username, req_body["password"], req_body["host"])
+					if ok then 
+						hosts[req_body["host"]].events.fire_event("user-registered", { username = username, host = req_body["host"], source = "mod_register_json", session = { ip = req_body["ip"] } })
+						module:log("debug", "%s registration data submission for %s@%s is successful", user, username, req_body["host"])
+						return http_response(200, "Done.")
+					else
+						module:log("error", "user creation failed: "..error)
+						return http_response(500, "Encountered server error while creating the user: "..error)
+					end
 				end
 			else
 				module:log("debug", "%s registration data submission for %s failed (user already exists)", user, username)