# HG changeset patch
# User Kim Alvefur <zash@zash.se>
# Date 1579980132 -3600
# Node ID c0df50ce96f0bd84aaaf646ecbdb06790a6f9ded
# Parent  a44e20cbd9869374d649c0b52aaa69640591362a
mod_rest: Handle internal http request errors early and then return

Skips over attempted parsing of the payload which usually failed since
the body is an error string like "connection refused", so this produced
useless errors.

diff -r a44e20cbd986 -r c0df50ce96f0 mod_rest/mod_rest.lua
--- a/mod_rest/mod_rest.lua	Sat Jan 25 20:16:01 2020 +0100
+++ b/mod_rest/mod_rest.lua	Sat Jan 25 20:22:12 2020 +0100
@@ -224,6 +224,8 @@
 			}, function (body, code, response)
 				if code == 0 then
 					module:log_status("error", "Could not connect to callback URL %q: %s", rest_url, body);
+					origin.send(st.error_reply(stanza, "wait", "recipient-unavailable", body));
+					return;
 				else
 					module:set_status("info", "Connected");
 				end
@@ -275,8 +277,6 @@
 						reply = st.error_reply(stanza, "modify", "bad-request", body);
 					elseif code_hundreds == 500 then
 						reply = st.error_reply(stanza, "cancel", "internal-server-error", body);
-					elseif code == 0 then
-						reply = st.error_reply(stanza, "wait", "recipient-unavailable", body);
 					else
 						reply = st.error_reply(stanza, "cancel", "undefined-condition", body);
 					end