# HG changeset patch
# User Kim Alvefur <zash@zash.se>
# Date 1630347549 -7200
# Node ID dbc7ba3cc27c6c1431d590944c77fe1a5a8acde7
# Parent  f0ffa8cf3ce6b7062a598dfeefe8ff702e817742
mod_external_services: Filter services by requested credentials using a Set

Please don't be accidentally quadratic.

diff -r f0ffa8cf3ce6 -r dbc7ba3cc27c mod_external_services/mod_external_services.lua
--- a/mod_external_services/mod_external_services.lua	Sun Aug 29 23:26:19 2021 +0200
+++ b/mod_external_services/mod_external_services.lua	Mon Aug 30 20:19:09 2021 +0200
@@ -5,6 +5,7 @@
 local st = require "util.stanza";
 local jid = require "util.jid";
 local array = require "util.array";
+local set = require "util.set";
 
 local default_host = module:get_option_string("external_service_host", module.host);
 local default_port = module:get_option_number("external_service_port");
@@ -179,22 +180,18 @@
 		return item.restricted;
 	end)
 
-	local requested_credentials = {};
+	local requested_credentials = set.new();
 	for service in action:childtags("service") do
 		if not service.attr.type or not service.attr.host then
 			origin.send(st.error_reply(stanza, "modify", "bad-request"));
 			return true;
 		end
 
-		table.insert(requested_credentials, {
-				type = service.attr.type;
-				host = service.attr.host;
-				port = tonumber(service.attr.port);
-			});
+		requested_credentials:add(string.format("%s:%s:%d", service.attr.type, service.attr.host,
+			tonumber(service.attr.port) or 0));
 	end
 
 	setmetatable(services, services_mt);
-	setmetatable(requested_credentials, services_mt);
 
 	module:fire_event("external_service/credentials", {
 			origin = origin;
@@ -204,22 +201,23 @@
 			services = services;
 		});
 
-	for req_srv in action:childtags("service") do
-		for _, srv in ipairs(services) do
-			if srv.type == req_srv.attr.type and srv.host == req_srv.attr.host
-				and not req_srv.attr.port or srv.port == tonumber(req_srv.attr.port) then
-				reply:tag("service", {
-						type = srv.type;
-						transport = srv.transport;
-						host = srv.host;
-						port = srv.port and string.format("%d", srv.port) or nil;
-						username = srv.username;
-						password = srv.password;
-						expires = srv.expires and dt.datetime(srv.expires) or nil;
-						restricted = srv.restricted and "1" or nil;
-					}):up();
-			end
-		end
+	services:filter(function (srv)
+		local port_key = string.format("%s:%s:%d", srv.type, srv.host, srv.port or 0);
+		local portless_key = string.format("%s:%s:%d", srv.type, srv.host, 0);
+		return requested_credentials:contains(port_key) or requested_credentials:contains(portless_key);
+	end);
+
+	for _, srv in ipairs(services) do
+		reply:tag("service", {
+				type = srv.type;
+				transport = srv.transport;
+				host = srv.host;
+				port = srv.port and string.format("%d", srv.port) or nil;
+				username = srv.username;
+				password = srv.password;
+				expires = srv.expires and dt.datetime(srv.expires) or nil;
+				restricted = srv.restricted and "1" or nil;
+			}):up();
 	end
 
 	origin.send(reply);