changeset 5038:88980b2dd986

mod_sasl2: Hacky support for channel binding We should work out how to share this code properly between here and mod_saslauth.
author Matthew Wild <mwild1@gmail.com>
date Tue, 06 Sep 2022 16:01:12 +0100
parents 8a8100fff580
children c0d243b27e64
files mod_sasl2/mod_sasl2.lua
diffstat 1 files changed, 41 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/mod_sasl2/mod_sasl2.lua	Sun Sep 04 09:51:36 2022 +0100
+++ b/mod_sasl2/mod_sasl2.lua	Tue Sep 06 16:01:12 2022 +0100
@@ -11,6 +11,7 @@
 local errors = require "util.error";
 local base64 = require "util.encodings".base64;
 local jid_join = require "util.jid".join;
+local set = require "util.set";
 
 local usermanager_get_sasl_handler = require "core.usermanager".get_sasl_handler;
 local sm_make_authenticated = require "core.sessionmanager".make_authenticated;
@@ -23,6 +24,19 @@
 
 local host = module.host;
 
+local function tls_unique(self)
+	return self.userdata["tls-unique"]:ssl_peerfinished();
+end
+
+local function tls_exporter(conn)
+	if not conn.ssl_exportkeyingmaterial then return end
+	return conn:ssl_exportkeyingmaterial("EXPORTER-Channel-Binding", 32, "");
+end
+
+local function sasl_tls_exporter(self)
+	return tls_exporter(self.userdata["tls-exporter"]);
+end
+
 module:hook("stream-features", function(event)
 	local origin, features = event.origin, event.features;
 	local log = origin.log or module._log;
@@ -35,8 +49,33 @@
 	local sasl_handler = usermanager_get_sasl_handler(host, origin)
 	origin.sasl_handler = sasl_handler;
 
-	if sasl_handler.add_cb_handler then -- luacheck: ignore 542
-		-- FIXME bring back channel binding
+	local channel_bindings = set.new()
+	if origin.encrypted then
+		-- check whether LuaSec has the nifty binding to the function needed for tls-unique
+		-- FIXME: would be nice to have this check only once and not for every socket
+		if sasl_handler.add_cb_handler then
+			local info = origin.conn:ssl_info();
+			if info and info.protocol == "TLSv1.3" then
+				log("debug", "Channel binding 'tls-unique' undefined in context of TLS 1.3");
+				if tls_exporter(origin.conn) then
+					log("debug", "Channel binding 'tls-exporter' supported");
+					sasl_handler:add_cb_handler("tls-exporter", sasl_tls_exporter);
+					channel_bindings:add("tls-exporter");
+				end
+			elseif origin.conn.ssl_peerfinished and origin.conn:ssl_peerfinished() then
+				log("debug", "Channel binding 'tls-unique' supported");
+				sasl_handler:add_cb_handler("tls-unique", tls_unique);
+				channel_bindings:add("tls-unique");
+			else
+				log("debug", "Channel binding 'tls-unique' not supported (by LuaSec?)");
+			end
+			sasl_handler["userdata"] = {
+				["tls-unique"] = origin.conn;
+				["tls-exporter"] = origin.conn;
+			};
+		else
+			log("debug", "Channel binding not supported by SASL handler");
+		end
 	end
 
 	local mechanisms = st.stanza("mechanisms", { xmlns = xmlns_sasl2 });