changeset 5085:e384b91d0aa7

mod_clean_roster: Clean out invalid characters from roster entires
author Kim Alvefur <zash@zash.se>
date Tue, 22 Nov 2022 16:59:52 +0100
parents dda2af7ed02f
children dec4b2e31d1c
files mod_clean_roster/README.md mod_clean_roster/mod_clean_roster.lua
diffstat 2 files changed, 65 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/mod_clean_roster/README.md	Tue Nov 22 16:59:52 2022 +0100
@@ -0,0 +1,5 @@
+Removes invalid characters from roster entries.
+
+```bash
+sudo prosodyctl mod_clean_roster
+```
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/mod_clean_roster/mod_clean_roster.lua	Tue Nov 22 16:59:52 2022 +0100
@@ -0,0 +1,60 @@
+local s_find = string.find;
+
+local pctl = require "util.prosodyctl";
+
+local rostermanager = require "core.rostermanager";
+local storagemanager = require "core.storagemanager";
+local usermanager = require "core.usermanager";
+
+-- copypaste from util.stanza
+local function valid_xml_cdata(str, attr)
+	return not s_find(str, attr and "[^\1\9\10\13\20-~\128-\247]" or "[^\9\10\13\20-~\128-\247]");
+end
+
+function module.command(_arg)
+	if select(2, pctl.isrunning()) then
+		pctl.show_warning("Stop Prosody before running this command");
+		return 1;
+	end
+
+	for hostname, host in pairs(prosody.hosts) do
+		if hostname ~= "*" then
+			if host.users.name == "null" then
+				storagemanager.initialize_host(hostname);
+				usermanager.initialize_host(hostname);
+			end
+			local fixes = 0;
+			for username in host.users.users() do
+				local roster = rostermanager.load_roster(username, hostname);
+				local changed = false;
+				for contact, item in pairs(roster) do
+					if contact ~= false then
+						if item.name and not valid_xml_cdata(item.name, false) then
+							item.name = item.name:gsub("[^\9\10\13\20-~\128-\247]", "�");
+							fixes = fixes + 1;
+							changed = true;
+						end
+						local clean_groups = {};
+						for group in pairs(item.groups) do
+							if valid_xml_cdata(group, false) then
+								clean_groups[group] = true;
+							else
+								clean_groups[group:gsub("[^\9\10\13\20-~\128-\247]",  "�")] = true;
+								fixes = fixes + 1;
+								changed = true;
+							end
+						end
+						item.groups = clean_groups;
+					else
+						-- pending entries etc
+					end
+				end
+				if changed then
+					assert(rostermanager.save_roster(username, hostname, roster));
+				end
+			end
+			pctl.show_message("Fixed %d items on host %s", fixes, hostname);
+		end
+	end
+	return 0;
+end