changeset 2198:eb53a830864c

mod_cloud_notify: default false for sending body and sender
author Chris Ballinger <chrisballinger@gmail.com>
date Thu, 02 Jun 2016 14:07:22 -0700
parents 90a444ccaa8e
children 2582d09d2ec4
files mod_cloud_notify/README.markdown mod_cloud_notify/mod_cloud_notify.lua
diffstat 2 files changed, 12 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/mod_cloud_notify/README.markdown	Wed Jun 01 22:33:51 2016 +0200
+++ b/mod_cloud_notify/README.markdown	Thu Jun 02 14:07:22 2016 -0700
@@ -18,6 +18,16 @@
 
 App servers are notified about offline messages.
 
+Configuration
+=============
+
+  Option                         Default           Description
+  ------------------------------ ----------------- -----------------------------------------------------------------------------------------
+  `push_notification_with_body`      false   Whether or not to send the message body to remote pubsub node.
+  `push_notification_with_sender`           false             Whether or not to send the message sender to remote pubsub node.
+
+There are privacy implications for enabling these options because plaintext content and metadata will be shared with centralized servers (the pubsub node) run by arbitrary app developers.
+
 Installation
 ============
 
--- a/mod_cloud_notify/mod_cloud_notify.lua	Wed Jun 01 22:33:51 2016 +0200
+++ b/mod_cloud_notify/mod_cloud_notify.lua	Thu Jun 02 14:07:22 2016 -0700
@@ -11,8 +11,8 @@
 local xmlns_push = "urn:xmpp:push:0";
 
 -- configuration
-local include_body = module:get_option("push_notification_with_body", true);
-local include_sender = module:get_option("push_notification_with_sender", true);
+local include_body = module:get_option("push_notification_with_body", false);
+local include_sender = module:get_option("push_notification_with_sender", false);
 
 -- For keeping state across reloads
 local push_enabled = module:shared("push-enabled-users");