changeset 2135:4e67d6ffea66

quick app: check type in notify
author Goffi <goffi@goffi.org>
date Sun, 05 Feb 2017 14:55:21 +0100
parents f45250052846
children cc3a6aea9508
files frontends/src/quick_frontend/constants.py frontends/src/quick_frontend/quick_app.py
diffstat 2 files changed, 4 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/frontends/src/quick_frontend/constants.py	Sun Feb 05 14:55:21 2017 +0100
+++ b/frontends/src/quick_frontend/constants.py	Sun Feb 05 14:55:21 2017 +0100
@@ -86,7 +86,8 @@
     LISTENERS = {'avatar', 'nick', 'presence', 'profilePlugged', 'disconnect', 'gotMenus', 'menu', 'notification', 'notificationsClear', 'progressFinished', 'progressError'}
 
     # Notifications
-    NOTIFY_MESSAGE = 'MESSAGE'  # a message was received
-    NOTIFY_MENTION = 'MENTION'  # user was mentionned
+    NOTIFY_MESSAGE = 'MESSAGE'  # a message has been received
+    NOTIFY_MENTION = 'MENTION'  # user has been mentionned
     NOTIFY_PROGRESS_END = 'PROGRESS_END'  # a progression has finised
     NOTIFY_GENERIC = 'GENERIC'  # a notification which has not its own type
+    NOTIFY_ALL = (NOTIFY_MESSAGE, NOTIFY_MENTION, NOTIFY_PROGRESS_END, NOTIFY_GENERIC)
--- a/frontends/src/quick_frontend/quick_app.py	Sun Feb 05 14:55:21 2017 +0100
+++ b/frontends/src/quick_frontend/quick_app.py	Sun Feb 05 14:55:21 2017 +0100
@@ -636,6 +636,7 @@
         @param cb_args(list, None): list of args for callback
         @param widget(object, None): widget where the notification happened
         """
+        assert type_ in C.NOTIFY_ALL
         notif_dict = self.profiles[profile].notifications
         key = '' if entity is None else entity.bare
         type_notifs = notif_dict.setdefault(key, {}).setdefault(type_, [])