Mercurial > libervia-backend

comparison sat/bridge/bridge_constructor/constructors/dbus-xml/constructor.py @ 4037:524856bd7b19

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
massive refactoring to switch from camelCase to snake_case: historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a pre-PEP8 code, to use the same coding style as in Twisted. However, snake_case is more readable and it's better to follow PEP8 best practices, so it has been decided to move on full snake_case. Because Libervia has a huge codebase, this ended with a ugly mix of camelCase and snake_case. To fix that, this patch does a big refactoring by renaming every function and method (including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case. This is a massive change, and may result in some bugs.
author Goffi <goffi@goffi.org>
date Sat, 08 Apr 2023 13:54:42 +0200
parents 7550ae9cfbac
children
comparison
equal deleted inserted replaced
4036:c4464d7ae97b 4037:524856bd7b19
36 "a{i(ss)}": "HistoryT", 36 "a{i(ss)}": "HistoryT",
37 "a(sss)": "QList<MenuT>", 37 "a(sss)": "QList<MenuT>",
38 "a{sa{s(sia{ss})}}": "PresenceStatusT", 38 "a{sa{s(sia{ss})}}": "PresenceStatusT",
39 } 39 }
40 40
41 def generateCoreSide(self): 41 def generate_core_side(self):
42 try: 42 try:
43 doc = minidom.parse(self.getTemplatePath(self.template)) 43 doc = minidom.parse(self.get_template_path(self.template))
44 interface_elt = doc.getElementsByTagName("interface")[0] 44 interface_elt = doc.getElementsByTagName("interface")[0]
45 except IOError: 45 except IOError:
46 print("Can't access template") 46 print("Can't access template")
47 sys.exit(1) 47 sys.exit(1)
48 except IndexError: 48 except IndexError:
58 "method" if function["type"] == "method" else "signal" 58 "method" if function["type"] == "method" else "signal"
59 ) 59 )
60 new_elt.setAttribute("name", section) 60 new_elt.setAttribute("name", section)
61 61
62 idx = 0 62 idx = 0
63 args_doc = self.getArgumentsDoc(section) 63 args_doc = self.get_arguments_doc(section)
64 for arg in self.argumentsParser(function["sig_in"] or ""): 64 for arg in self.arguments_parser(function["sig_in"] or ""):
65 arg_elt = doc.createElement("arg") 65 arg_elt = doc.createElement("arg")
66 arg_elt.setAttribute( 66 arg_elt.setAttribute(
67 "name", args_doc[idx][0] if idx in args_doc else "arg_%i" % idx 67 "name", args_doc[idx][0] if idx in args_doc else "arg_%i" % idx
68 ) 68 )
69 arg_elt.setAttribute("type", arg) 69 arg_elt.setAttribute("type", arg)
97 new_elt.appendChild(annot_elt) 97 new_elt.appendChild(annot_elt)
98 98
99 interface_elt.appendChild(new_elt) 99 interface_elt.appendChild(new_elt)
100 100
101 # now we write to final file 101 # now we write to final file
102 self.finalWrite(self.core_dest, [doc.toprettyxml()]) 102 self.final_write(self.core_dest, [doc.toprettyxml()])