Mercurial > libervia-backend
diff sat/bridge/bridge_constructor/constructors/dbus-xml/constructor.py @ 4037:524856bd7b19
massive refactoring to switch from camelCase to snake_case:
historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.
However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.
To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.
This is a massive change, and may result in some bugs.
| author | Goffi <goffi@goffi.org> |
|---|---|
| date | Sat, 08 Apr 2023 13:54:42 +0200 |
| parents | 7550ae9cfbac |
| children |
line wrap: on
line diff
--- a/sat/bridge/bridge_constructor/constructors/dbus-xml/constructor.py Fri Apr 07 15:18:39 2023 +0200 +++ b/sat/bridge/bridge_constructor/constructors/dbus-xml/constructor.py Sat Apr 08 13:54:42 2023 +0200 @@ -38,9 +38,9 @@ "a{sa{s(sia{ss})}}": "PresenceStatusT", } - def generateCoreSide(self): + def generate_core_side(self): try: - doc = minidom.parse(self.getTemplatePath(self.template)) + doc = minidom.parse(self.get_template_path(self.template)) interface_elt = doc.getElementsByTagName("interface")[0] except IOError: print("Can't access template") @@ -60,8 +60,8 @@ new_elt.setAttribute("name", section) idx = 0 - args_doc = self.getArgumentsDoc(section) - for arg in self.argumentsParser(function["sig_in"] or ""): + args_doc = self.get_arguments_doc(section) + for arg in self.arguments_parser(function["sig_in"] or ""): arg_elt = doc.createElement("arg") arg_elt.setAttribute( "name", args_doc[idx][0] if idx in args_doc else "arg_%i" % idx @@ -99,4 +99,4 @@ interface_elt.appendChild(new_elt) # now we write to final file - self.finalWrite(self.core_dest, [doc.toprettyxml()]) + self.final_write(self.core_dest, [doc.toprettyxml()])