Mercurial > libervia-backend

comparison sat/bridge/bridge_constructor/constructors/embedded/embedded_template.py @ 4037:524856bd7b19

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
massive refactoring to switch from camelCase to snake_case: historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a pre-PEP8 code, to use the same coding style as in Twisted. However, snake_case is more readable and it's better to follow PEP8 best practices, so it has been decided to move on full snake_case. Because Libervia has a huge codebase, this ended with a ugly mix of camelCase and snake_case. To fix that, this patch does a big refactoring by renaming every function and method (including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case. This is a massive change, and may result in some bugs.
author Goffi <goffi@goffi.org>
date Sat, 08 Apr 2023 13:54:42 +0200
parents 7550ae9cfbac
children
comparison
equal deleted inserted replaced
4036:c4464d7ae97b 4037:524856bd7b19
27 def __init__(self): 27 def __init__(self):
28 log.debug("Init embedded bridge...") 28 log.debug("Init embedded bridge...")
29 self._methods_cbs = {} 29 self._methods_cbs = {}
30 self._signals_cbs = {"core": {}, "plugin": {}} 30 self._signals_cbs = {"core": {}, "plugin": {}}
31 31
32 def bridgeConnect(self, callback, errback): 32 def bridge_connect(self, callback, errback):
33 callback() 33 callback()
34 34
35 def register_method(self, name, callback): 35 def register_method(self, name, callback):
36 log.debug("registering embedded bridge method [{}]".format(name)) 36 log.debug("registering embedded bridge method [{}]".format(name))
37 if name in self._methods_cbs: 37 if name in self._methods_cbs:
83 except KeyError: 83 except KeyError:
84 log.debug("ignoring signal {}: no callback registered".format(name)) 84 log.debug("ignoring signal {}: no callback registered".format(name))
85 else: 85 else:
86 cb(*args, **kwargs) 86 cb(*args, **kwargs)
87 87
88 def addMethod(self, name, int_suffix, in_sign, out_sign, method, async_=False, doc={}): 88 def add_method(self, name, int_suffix, in_sign, out_sign, method, async_=False, doc={}):
89 # FIXME: doc parameter is kept only temporary, the time to remove it from calls 89 # FIXME: doc parameter is kept only temporary, the time to remove it from calls
90 log.debug("Adding method [{}] to embedded bridge".format(name)) 90 log.debug("Adding method [{}] to embedded bridge".format(name))
91 self.register_method(name, method) 91 self.register_method(name, method)
92 setattr( 92 setattr(
93 self.__class__, 93 self.__class__,
95 lambda self_, *args, **kwargs: self.call_method( 95 lambda self_, *args, **kwargs: self.call_method(
96 name, out_sign, async_, args, kwargs 96 name, out_sign, async_, args, kwargs
97 ), 97 ),
98 ) 98 )
99 99
100 def addSignal(self, name, int_suffix, signature, doc={}): 100 def add_signal(self, name, int_suffix, signature, doc={}):
101 setattr( 101 setattr(
102 self.__class__, 102 self.__class__,
103 name, 103 name,
104 lambda self_, *args, **kwargs: self.send_signal(name, args, kwargs), 104 lambda self_, *args, **kwargs: self.send_signal(name, args, kwargs),
105 ) 105 )
114 114
115 # we want the same instance for both core and frontend 115 # we want the same instance for both core and frontend
116 bridge = None 116 bridge = None
117 117
118 118
119 def Bridge(): 119 def bridge():
120 global bridge 120 global bridge
121 if bridge is None: 121 if bridge is None:
122 bridge = _Bridge() 122 bridge = _Bridge()
123 return bridge 123 return bridge