Mercurial > libervia-backend
diff sat/bridge/bridge_constructor/constructors/embedded/embedded_template.py @ 4037:524856bd7b19
massive refactoring to switch from camelCase to snake_case:
historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.
However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.
To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.
This is a massive change, and may result in some bugs.
| author | Goffi <goffi@goffi.org> |
|---|---|
| date | Sat, 08 Apr 2023 13:54:42 +0200 |
| parents | 7550ae9cfbac |
| children |
line wrap: on
line diff
--- a/sat/bridge/bridge_constructor/constructors/embedded/embedded_template.py Fri Apr 07 15:18:39 2023 +0200 +++ b/sat/bridge/bridge_constructor/constructors/embedded/embedded_template.py Sat Apr 08 13:54:42 2023 +0200 @@ -29,7 +29,7 @@ self._methods_cbs = {} self._signals_cbs = {"core": {}, "plugin": {}} - def bridgeConnect(self, callback, errback): + def bridge_connect(self, callback, errback): callback() def register_method(self, name, callback): @@ -85,7 +85,7 @@ else: cb(*args, **kwargs) - def addMethod(self, name, int_suffix, in_sign, out_sign, method, async_=False, doc={}): + def add_method(self, name, int_suffix, in_sign, out_sign, method, async_=False, doc={}): # FIXME: doc parameter is kept only temporary, the time to remove it from calls log.debug("Adding method [{}] to embedded bridge".format(name)) self.register_method(name, method) @@ -97,7 +97,7 @@ ), ) - def addSignal(self, name, int_suffix, signature, doc={}): + def add_signal(self, name, int_suffix, signature, doc={}): setattr( self.__class__, name, @@ -116,7 +116,7 @@ bridge = None -def Bridge(): +def bridge(): global bridge if bridge is None: bridge = _Bridge()